Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T289471: Include ellipsis in context with bdi text #150

Merged
merged 2 commits into from
Sep 30, 2021
Merged

T289471: Include ellipsis in context with bdi text #150

merged 2 commits into from
Sep 30, 2021

Conversation

medied
Copy link
Contributor

@medied medied commented Sep 28, 2021

https://phabricator.wikimedia.org/T289471

Follow up to #149, this include the ellipsis in context with <bdi> text

image

@hueitan
Copy link
Member

hueitan commented Sep 28, 2021

it works well for me in this form without additional


image

@medied
Copy link
Contributor Author

medied commented Sep 28, 2021

You mean replacing the <div> directly with a <bdi> and nothing else? From my testing I see that messes with the text placement for shorter strings though

image

@hueitan
Copy link
Member

hueitan commented Sep 28, 2021

I got some inspiration from your commit max-width, and it works better, i like the simpler way directly with <bdi>
image

@medied
Copy link
Contributor Author

medied commented Sep 28, 2021

Okay that seems to work well, updated now

hueitan
hueitan approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@hueitan hueitan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
@jpita test is carefully.

@jpita
Copy link
Contributor

jpita commented Sep 29, 2021

do we have preview deploying to a branch named test environment like kaios?

@stephanebisson
Copy link
Collaborator

Not yet

@jpita
Copy link
Contributor

jpita commented Sep 30, 2021

can someone merge this?
I messed up with the github permissions and can't merge code right now

@hueitan hueitan merged commit 713d586 into main Sep 30, 2021
@hueitan hueitan deleted the T289471-bdi-folllowup branch September 30, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hueitan hueitan hueitan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@medied @hueitan @jpita @stephanebisson