Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle the offline state having no cta footer #145

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Handle the offline state having no cta footer #145

merged 1 commit into from
Sep 1, 2021

Conversation

stephanebisson
Copy link
Collaborator

The offline state doesn't have a footer with the "read on wiki" CTA. The code that tries to bind an even to that CTA crashes.

@stephanebisson stephanebisson requested a review from a team August 31, 2021 19:14
@stephanebisson stephanebisson merged commit 2dc498d into main Sep 1, 2021
@stephanebisson stephanebisson deleted the offline-no-cta branch September 1, 2021 12:55
@stephanebisson stephanebisson restored the offline-no-cta branch July 28, 2022 12:57
@stephanebisson stephanebisson deleted the offline-no-cta branch July 28, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medied medied medied approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephanebisson @medied