Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T282717 Add target stories for hyperlink, image and text #119

Merged
merged 4 commits into from
Jun 7, 2021
Merged

T282717 Add target stories for hyperlink, image and text #119

merged 4 commits into from
Jun 7, 2021

Conversation

hueitan
Copy link
Member

@hueitan hueitan commented Jun 3, 2021 •
edited
Loading

Phabricator Ticket: https://phabricator.wikimedia.org/T282717

  • add target stories
  • (Out ot scope, move to another ticket) add image in the demo page as the example

@hueitan hueitan marked this pull request as draft June 3, 2021 21:48
@hueitan hueitan marked this pull request as ready for review June 7, 2021 14:18
@hueitan hueitan requested a review from a team June 7, 2021 14:18
stephanebisson
stephanebisson reviewed Jun 7, 2021
View reviewed changes
src/stories/target.stories.js Outdated
import { init } from '../index'

export default {
title: 'Target Cases',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe name that Targets without the "cases"

@stephanebisson stephanebisson merged commit d0c911a into main Jun 7, 2021
@stephanebisson stephanebisson deleted the T282717-target-stories branch June 7, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanebisson stephanebisson stephanebisson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hueitan @stephanebisson