Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for the unique autonyms test #383

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Conversation

amire80
Copy link
Collaborator

@amire80 amire80 commented Sep 7, 2024

  1. Move the unique autonyms test to the "autonyms" section

It was in the "redirects" section, and it makes much more sense for it to be in the "autonyms" section.

  1. Case-insensitive test for unique autonyms

Autonyms for some languages are very similar or even identical, but they should be unique in this system so that users would be able to find the correct language unambiguously.

It's conceivable that someone (including myself) would add an autonym that will be different only in its usage of capital letters. This change modifies the test for unique autonyms so that such cases would be prevented.

It was in the "redirects" section, and it makes
much more sense for it to be in the "autonyms" section.
Autonyms for some languages are very similar or even identical,
but they should be unique in this system so that users
would be able to find the correct language unambiguously.

It's conceivable that someone (including myself) would add
an autonym that will be different only in its usage of
capital letters. This change modifies the test for
unique autonyms so that such cases would be prevented.
@srish srish merged commit 655657f into wikimedia:master Sep 18, 2024
7 checks passed
@amire80 amire80 deleted the unique-autonyms branch September 24, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants