Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skin-invert class to two icons #496

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jhsoby
Copy link
Contributor

@jhsoby jhsoby commented Nov 26, 2024

In order to support dark mode in Vector-2022 (and other places?). This pull request is tied with this Gerrit change to the ULS extension; that change depends on this one.

In order to support dark mode in Vector-2022 (and other places)?
@srish srish requested review from jdlrobson and Volker-E November 26, 2024 15:42
Copy link
Member

@jdlrobson jdlrobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would break the ULS in current form given ULS is using the skin-theme class now? I suspect this was written prior to that change.

Can you confirm?

@jdlrobson
Copy link
Member

Applying the classes to ULS this is what I would expect to see (I'm not setup to test the library so perhaps I'm misunderstanding how this is put together and maybe there are other local changes I am missing?)

Screenshot 2024-11-26 at 8 36 23 AM

@jhsoby
Copy link
Contributor Author

jhsoby commented Nov 26, 2024

I made this PR as part of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UniversalLanguageSelector/+/1098036 … not sure how to add "Depends-On" across Gerrit/GitHub, sorry (but I can just add it "manually" to the commit message of course).

@jdlrobson
Copy link
Member

Ah got it! Thanks for that context!

@jhsoby
Copy link
Contributor Author

jhsoby commented Nov 30, 2024

Could we merge this? My understanding from Niklas's comment on Gerrit is that we will need to pull the changes from this GitHub repo into the ULS extension "manually", so merging this here won't immediately have any effect on-wiki. And these changes are needed for the Gerrit patch to work properly.

@jdlrobson
Copy link
Member

Whoever merges this should be able to commit to making the necessary preparations in production extensions that use this library (as someone unfamiliar with this code and consumers I can't be that person but the change makes sense in the context of the other changes @jhsoby has proposed).

@srish srish requested a review from Nikerabbit December 4, 2024 11:48
@jhsoby
Copy link
Contributor Author

jhsoby commented Dec 7, 2024

Actually, please hold on a bit – I think I found a way to do this in the extension without relying on skin-invert at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants