-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skin-invert
class to two icons
#496
base: master
Are you sure you want to change the base?
Conversation
In order to support dark mode in Vector-2022 (and other places)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would break the ULS in current form given ULS is using the skin-theme
class now? I suspect this was written prior to that change.
Can you confirm?
I made this PR as part of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UniversalLanguageSelector/+/1098036 … not sure how to add "Depends-On" across Gerrit/GitHub, sorry (but I can just add it "manually" to the commit message of course). |
Ah got it! Thanks for that context! |
Could we merge this? My understanding from Niklas's comment on Gerrit is that we will need to pull the changes from this GitHub repo into the ULS extension "manually", so merging this here won't immediately have any effect on-wiki. And these changes are needed for the Gerrit patch to work properly. |
Whoever merges this should be able to commit to making the necessary preparations in production extensions that use this library (as someone unfamiliar with this code and consumers I can't be that person but the change makes sense in the context of the other changes @jhsoby has proposed). |
Actually, please hold on a bit – I think I found a way to do this in the extension without relying on skin-invert at all. |
In order to support dark mode in Vector-2022 (and other places?). This pull request is tied with this Gerrit change to the ULS extension; that change depends on this one.