Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repositories not loaded from merged packages #4

Closed
bd808 opened this issue Dec 24, 2014 · 1 comment · Fixed by #8
Closed

Repositories not loaded from merged packages #4

bd808 opened this issue Dec 24, 2014 · 1 comment · Fixed by #8
Labels
bug
Milestone
1.0

Comments

@bd808
Copy link
Member

bd808 commented Dec 24, 2014

It turns out that ArrayLoader doesn't populate the repositories section of the Package objects it creates, so the code that attempts to merge repositories with the base package doesn't fire even if the package declares custom repositories. Likely related to https://getcomposer.org/doc/faqs/why-can%27t-composer-load-repositories-recursively.md
@bd808 bd808 added the bug label Dec 24, 2014
@bd808
Copy link
Member Author

bd808 commented Dec 24, 2014

I'm not sure if this should be a 1.0 blocker or not yet.

bd808 added a commit to bd808/composer-merge-plugin that referenced this issue Dec 26, 2014
@bd808
Add repositories to repository manager
c454905 
Manually create and add repository objects defined in merged files.

Closes wikimedia#4
@bd808 bd808 mentioned this issue Dec 26, 2014
Merged
@bd808 bd808 added this to the 1.0 milestone Dec 26, 2014
bd808 added a commit to bd808/composer-merge-plugin that referenced this issue Dec 26, 2014
@bd808
Add repositories to repository manager
9f48ebf 
Manually create and add repository objects defined in merged files.

Closes wikimedia#4
@bd808 bd808 closed this as completed in #8 Dec 26, 2014
barlambe referenced this issue Nov 28, 2020
@reedy @bd808
[WIP] Support Composer 2.0 plugin API changes
7274d02 
Add initial support for the upcoming Composer 2.0 release:
* Allow either ^1.1 or ^2.0 composer-plugin-api
* Implement new PluginInterface methods (as no-op)
* Prefer InstallerEvents::PRE_OPERATIONS_EXEC over
  InstallerEvents::PRE_DEPENDENCIES_SOLVING when available

Bug: T248908
Co-authored-by: Bryan Davis <bd808@wikimedia.org>
@jimrome jimrome mentioned this issue Dec 10, 2020
Closed
@barlambe barlambe mentioned this issue Feb 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Add repositories to repository manager bd808/composer-merge-plugin
1 participant
@bd808