gender: when gender not passed, avoid error, fallback to neutral #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Messages like {{GENDER:|A|B|C}} were causing parser failures.
This patch fixes the parser and introduce a fallback to neutral form.
As a mediawiki independent library, while Gender is supported, we cannot
support gender with current logged in user. For that explicit gender
param placeholder needed(example: {{GENDER:$1|A|B|C}}
|
I found this issue while testing https://phabricator.wikimedia.org/T271918. A few messages from hebrew has Gender without gender information. |
amire80
approved these changes
Sep 22, 2021
wmfgerrit
pushed a commit
to wikimedia/mediawiki-extensions-ContentTranslation
that referenced
this pull request
Sep 24, 2021
Banana-i18n updated improved i18n for RTL scripts wikimedia/banana-i18n#57 Bug: T271918 Change-Id: I2fe475fb6887cc73a153f51b79e5fa2115d15e3c
wmfgerrit
pushed a commit
to wikimedia/mediawiki-extensions
that referenced
this pull request
Sep 24, 2021
* Update ContentTranslation from branch 'master'
to ba1bebaaf2c5e0e0f9e95a3f1cd533681aaf1821
- SX: Update dependencies
Banana-i18n updated improved i18n for RTL scripts
wikimedia/banana-i18n#57
Bug: T271918
Change-Id: I2fe475fb6887cc73a153f51b79e5fa2115d15e3c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messages like {{GENDER:|A|B|C}} were causing parser failures.
This patch fixes the parser and introduce a fallback to neutral form.
As a mediawiki independent library, while Gender is supported, we cannot
support gender with current logged in user. For that explicit gender
param placeholder needed(example: {{GENDER:$1|A|B|C}}