Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library target is UMD which prevents library from being used in node.js #14

Closed
davidbarratt opened this issue Aug 13, 2019 · 1 comment · Fixed by #15 or #18
Closed

Library target is UMD which prevents library from being used in node.js #14

davidbarratt opened this issue Aug 13, 2019 · 1 comment · Fixed by #15 or #18

Comments

@davidbarratt
Copy link
Member

When I attempt to use this library in node.js I recieve the following error:

ReferenceError: window is not defined at Object. (/Users/dbarratt/Sites/wikimedia/interaction-timeline/next/node_modules/banana-i18n/dist/banana-i18n.js:1:194)

This seems to be because the libraryTarget is umd instead of commonjs2
@davidbarratt davidbarratt mentioned this issue Aug 13, 2019
Merged
@santhoshtr
Copy link
Member

New version released https://github.com/wikimedia/banana-i18n/releases/tag/v1.1.0

feildmaster added a commit to feildmaster/banana-i18n that referenced this issue Sep 14, 2019
@feildmaster
Set global object to "this"
0b06208 
Fixes wikimedia#14 while keeping web support
@feildmaster feildmaster mentioned this issue Sep 14, 2019
Merged
santhoshtr pushed a commit that referenced this issue Sep 14, 2019
@feildmaster @santhoshtr
Set globalObject to "this" (from default: window) (#18)
5c088a4 
* revert: Switch libraryTarget from umd to commonjs2

This is not the proper way to add support for Node, this breaks web support

* Set global object to "this"

Fixes #14 while keeping web support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@santhoshtr @davidbarratt