Merge pull request #9 from pols12/patch-1

MoreMenu.js: hides core Menu if empty

src/MoreMenu.js

@@ -909,13 +909,58 @@ $(() => {
         });
     }
 
+    /**
+     * Stores in LocalStorage with an expiry date (now + liveTime, in ms).
+     *
+     * @param {string} key Key name to store under
+     * @param {Object} value Object value to be stored
+     * @param {int} liveTime Delay in ms before to consider the value as outdated
+     * @return {boolean} The value was set
+     */
+    function setStorageWithExpiry(key, value, liveTime) {
+        return mw.storage.setObject(
+            key,
+            {
+                value: value,
+                expiryDate: (new Date()).getTime() + liveTime,
+            }
+        )
+    }
+
+    /**
+     * Retrieve mmNativeMenuUsage from LocalStorage and decrements it if
+     * its expiry date has been passed.
+     *
+     * @return {int|null|boolean} mmNativeMenuUsage, null if no value exists,
+     *  or false if storage is not available.
+     */
+    function getMmNativeMenuUsage() {
+        const obj = mw.storage.getObject('mmNativeMenuUsage');
+
+        if (!obj) { //mmNativeMenuUsage nonexistent, or LocalStorage not available
+            return obj;
+        }
+
+        //Let’s decrement value older than 24h
+        if ((new Date()).getTime() > obj.expiryDate) {
+            obj.value--;
+            setStorageWithExpiry('mmNativeMenuUsage', obj.value, 86400000);
+        }
+        if (0 == obj.value) {
+            mw.storage.remove('mmNativeMenuUsage');
+            return null;
+        }
+
+        return obj.value;
+    }
+
     /**
      * For Vector/Timeless's native More menu, we keep track of how many times it gets populated over time,
      * to intelligently determine whether we should leave it upfront to make the script feel more responsive.
      */
     function observeCactionsMenu() {
         /** Check local storage to see if user continually has items added to the native menu. */
-        const reAddCount = parseInt(mw.storage.get('mmNativeMenuUsage'), 10) || 0;
+        const reAddCount = parseInt(getMmNativeMenuUsage(), 10) || 0;
 
         /** Ignore for non-Vector/Timeless, if user disabled this feature, or if reAddCount is high. */
         if (-1 === ['vector', 'vector-2022', 'timeless'].indexOf(config.currentUser.skin)
@@ -930,7 +975,7 @@ $(() => {
         /** Wait 5 seconds before checking the reAddCount, to give other scripts time to populate the menu */
         setTimeout(() => {
             if ($('#p-cactions').find('li').length) {
-                mw.storage.set('mmNativeMenuUsage', reAddCount + 1);
+                setStorageWithExpiry('mmNativeMenuUsage', reAddCount + 1, 86400000); //24h liveTime
             }
         }, 5000);
     }