FIxed Bug In ModifyAllocation and a bug in Node.cc #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug rectified where DmgApWifiMac::ModifyAllocation would find the allocation it was trying to alter, then make a copy of the AllocationField and change the values in the copy rather than the original object.
…ot recieved by the AP This is only a problem when there is not 0 timeblockmeasurements in the m_measurementList. The problem occurs when the recieve function tries to access the data, it uses the NumberOfTimeBlocks value to access the data. The bug arose as the NumberOfTimeBlocks value was never included.
Fixed bug where a quality request would be schduled for a particular time period during a SP, starting a time X, but would instead simply be schduled for time X after the STA recieved the packet.
…sp2StartTime The first bug was where the two values were not set until the simulation had begun, this meant that the Simulator schdule at the bottom of the script, which scduled the first MeasureOverSP1/ MeasureOverSP2 would always scdule them with variable 0. The second bug fixed, is where the values for sp1StartTime and sp2StartTime were not actually set at thier respective start times, rather at the time that they ended, this caused problems when sending further channel quality requests.
hanyassasa87
force-pushed
the
master
branch
2 times, most recently
from
5526f17
to
f340423
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a number of bugs mostly do do with Channel quality reports and the scratch simulation evaluate_spatial_sharing_udp.