Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with @nomiclabs/hardhat-etherscan 3.0.0 #257

Closed
clifton opened this issue Jan 19, 2022 · 1 comment
Closed

Conflict with @nomiclabs/hardhat-etherscan 3.0.0 #257

clifton opened this issue Jan 19, 2022 · 1 comment

Comments

@clifton
Copy link

clifton commented Jan 19, 2022

a reincarnation of #106

@nomiclabs/hardhat-etherscan is 3.0.0
hardhat-deploy is 0.9.24

fixed by downgrading @nomiclabs/hardhat-etherscan to 2.1.8

node_modules/hardhat-deploy/dist/src/type-extensions.d.ts:24:9 - error TS2717: Subsequent property declarations must have the same type.  Property 'etherscan' must be of type 'EtherscanConfig | undefined', but here has type '{ apiKey?: string | undefined; } | undefined'.

24         etherscan?: {
           ~~~~~~~~~

  node_modules/@nomiclabs/hardhat-etherscan/dist/src/type-extensions.d.ts:5:9
    5         etherscan?: EtherscanConfig;
              ~~~~~~~~~
    'etherscan' was also declared here.

node_modules/hardhat-deploy/dist/src/type-extensions.d.ts:46:9 - error TS2717: Subsequent property declarations must have the same type.  Property 'etherscan' must be of type 'EtherscanConfig', but here has type '{ apiKey?: string | undefined; }'.

46         etherscan: {
           ~~~~~~~~~

  node_modules/@nomiclabs/hardhat-etherscan/dist/src/type-extensions.d.ts:8:9
    8         etherscan: EtherscanConfig;
              ~~~~~~~~~
    'etherscan' was also declared here.


Found 2 errors.
@wighawag
Copy link
Owner

should be fixed in 0.10.0 (breaking change: now hardhat-deploy use the verify field in hardhat.config

see : https://github.com/wighawag/hardhat-deploy#4-hardhat-etherscan-verify

michalinacienciala added a commit to threshold-network/solidity-contracts that referenced this issue Sep 19, 2022
Previously used `0.9.29` version was causing conflicts with the
`@nomiclabs/hardhat-etherscan` plugin (`Property 'etherscan' must be of type
'EtherscanUserConfig', but here has type '{ apiKey?: string; }'` during `npm
pubish`).
According to wighawag/hardhat-deploy#257 upgrading
`hardhat-deploy` to version `0.10.0` or higher should fix the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants