Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: use Mario's vuetify #977

Open
wants to merge 3 commits into
base: 12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults
Choose a base branch
from
Open

fix!: use Mario's vuetify #977

wants to merge 3 commits into from

Conversation

iisakkirotko
Copy link
Collaborator

@iisakkirotko iisakkirotko commented Jan 20, 2025 •
edited
Loading

All Submissions:

Description of changes

Previously we didn't use the same version of Vuetify as ipyvuetify does, which could result in discrepancies, for isntance with CSS.

Fixes #588.

@iisakkirotko Graphite App
Copy link
Collaborator Author

iisakkirotko commented Jan 20, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@iisakkirotko iisakkirotko force-pushed the 12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults branch from e925b44 to 70e86a3 Compare January 21, 2025 10:49
iisakkirotko and others added 2 commits January 31, 2025 12:02
@iisakkirotko
feat!: change mutation_detection and allow_reactive_boolean defaults
4a13075 
BREAKING CHANGE: an error is now raised if a reactive variable (not its value) is used in boolean comparisons
BREAKIGN CHANGE: mutation detection is now enabled by default
@iisakkirotko
fix!: solara Meta and Navigator elements insert empty span into D…
31a27a8 
…OM (#625)

* fix[docs]: solara.Meta elements insert empty span into DOM

* chore: remove workaround from jupyter notebook tutorial

Reverts #627, since the workaround is no longer needed.

* fix!: navigator would insert an empty span into dom
@iisakkirotko iisakkirotko force-pushed the 12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults branch from 70e86a3 to 31a27a8 Compare January 31, 2025 11:06
@iisakkirotko iisakkirotko force-pushed the 01-20-fix_use_mario_s_vuetify branch from 275e064 to c76eff8 Compare February 3, 2025 10:28
@iisakkirotko iisakkirotko force-pushed the 01-20-fix_use_mario_s_vuetify branch from c76eff8 to b9e7395 Compare February 3, 2025 15:38
@iisakkirotko iisakkirotko force-pushed the 12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults branch 2 times, most recently from a97b75b to 1d29010 Compare February 5, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@iisakkirotko