Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed animation on clicking rescan #848

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

removed animation on clicking rescan #848

wants to merge 2 commits into from

Conversation

schandrasv
Copy link

this PR fixes issue #844

Issue.fix.844.mp4

whyboris
whyboris requested changes Feb 24, 2024
View reviewed changes
Copy link
Owner

@whyboris whyboris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test the code, but I'm pretty sure the animation will no longer play when the user left clicks 😅

The animation should work when left-clicking (as the app will perform the rescan functionality) but right-clicking does not (and should not) perform the rescan ✅

@schandrasv
Copy link
Author

added another commit to fix the issue

@whyboris
Copy link
Owner

Thank you! I suspect this works great - will test and merge next time I'm doing some VHA coding (sometime during March); please let me know if you'd like it merged sooner 🙇‍♂️

@schandrasv schandrasv requested a review from whyboris May 18, 2024 16:19
@whyboris
Copy link
Owner

My house projects are taking so much longer than coding 😅
Refactoring an app can be as little as a few days of work; rebuilding a kitchen can take as long as many months 😓
I'll try to get to coding in the coming months, though I'm still deep in house work 🙇‍♂️
Thank you for your patience -- I intend to merge this PR this year; surely before any new VHA release occurs 🤝

@whyboris whyboris mentioned this pull request Sep 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyboris whyboris Awaiting requested review from whyboris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schandrasv @whyboris