-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't complain inside quotes #4
Comments
I'm no longer sure why this should be the case. |
Oh, I think this is talking about |
I am not sure if the new behavior makes sense. In the following sentence I don't think it makes sense to require a newline:
I interpreted the label of the ticket exactly the other way around. Before requiring a space following the dot / question mark it was warning about the missing newline which I though was not desired. But with the new behavior which needs a space afterwards I though the desired goal was already achieved - to not force a newline here. |
Hmmmmm...... Your point is valid. I might just revoke the behavior. @wooorm thoughts? I'm sure there are cases where a newline after Should I revoke this behavior? Feedback welcome. |
Maybe a better way to detect a sentence break is also by checking whether after the terminal-marker, there’s a upper-cases letter. Thus, |
I don't think that the case of the following letter can be used for that. E.g. any name would be upper case but doesn't imply a new sentence. I would rather avoid any false positives even if that means there are some false negatives left. |
I agree with @dirk-thomas. If one wants to add a newline, we should allow the freedom to do so. But we should not force it. I'm going to merge @dirk-thomas's PR #21 |
Do you guys think this is a breaking change? Should I update the major version? |
Yup, go for it :) |
The change was inserted just two days ago. I would just release a minor (or even patch). Anyway I am looking forward to use the upcoming version for our stuff 😉 Thanks. |
I normally wouldn’t care much either, the number of users is quite low and the chances of breaking builds is small, but still, they’re definitely breaking, so if you want to be more correct, go for a major! |
I'll go for a major bump. Thanks for the input. |
Are you going to release soon so that users can use this or are you waiting for other changes? |
I'll release it today. On Tuesday, January 12, 2016, Dirk Thomas notifications@github.com wrote:
|
No description provided.
The text was updated successfully, but these errors were encountered: