Wrong colorization in Yaml files

[sugdyzhekov]

Could you check following examples? Looks like Jinja colorization works wrong.

Example 1:

setup_plesk:
  cmd.run:
    - name: |
        PSA_PASSWORD={{ pass }} /usr/sbin/plesk bin init_conf --init -shared_ips add:{{ ip }} -license_agreed true -admin_info_not_required true -send_announce false -send_tech_announce false -hostname {{ fqdn }} -passwd "" -company plesk.ru -name Administrator -email {{ email }}
        ...

Example 2:

setup_plesk:
  cmd.run:
    - name: PSA_PASSWORD={{ pass }} /usr/sbin/plesk bin init_conf --init -shared_ips add:{{ ip }} -license_agreed true -admin_info_not_required true -send_announce false -send_tech_announce false -hostname {{ fqdn }} -passwd "" -company plesk.ru -name Administrator -email {{ email }}

Example 3:

create_default_subscription:
  cmd.run:
    - name: /usr/sbin/plesk bin subscription -c {{ fqdn }} -hosting true -ip {{ ip }} -login support -passwd $(/usr/bin/openssl rand -base64 12)
    - unless: /usr/sbin/plesk bin subscription -i {{ fqdn }} &>/dev/null

[wholroyd]

Thanks for letting me know about the issue.

The way VS Code handles languages is different depending on if they are core to the editor or come as an extension. Extensions can't override core languages very easily and have to use hackery sometimes to get things to work.

Give me a couple of days to take a look at it to see how to implement the changes.

[wholroyd]

To expand a bit on my last comment, see microsoft/vscode#1751 for more information on what I mean.

I can't immediately fix this issue without rewriting the YAML syntax from scratch or until Microsoft fixes the language override issue. This will take some time to fix, but I can do it.

[wholroyd]

At this point, I don't see myself being able to rewrite the YAML language to make this work and this is technically not a bug with the plugin, but a limitation of Code. As such, there is nothing I can really do about this until I get time or they fix language overrides in Code. I'm closing as Won't Fix for now.

[sugdyzhekov]

Ok, I got it. Thank you for your efforts!

чт, 10 нояб. 2016 г. в 9:51, William Holroyd notifications@github.com:

At this point, I don't see myself being able to rewrite the YAML language
to make this work and this is technically not a bug with the plugin, but a
limitation of Code. As such, there is nothing I can really do about this
until I get time or they fix language overrides in Code. I'm closing as
Won't Fix for now.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#3 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIilWZ8AtiT7ISHjP_q1IPZrGpdXE2uTks5q8obJgaJpZM4JGvMS
.

[wholroyd]

Wanted to let you know that VSCode added support for embedded and injected languages recently. How does this look?

[wholroyd]

Ended up getting blocked on this as it didn't work in YAML for all scenarios, so it's on pause.

Linking to #19.