Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onTouchStart mapped to this.handleDrag instead of this.handleStart ? #73

Closed
Squeezo opened this issue Jul 24, 2017 · 0 comments
Closed

onTouchStart mapped to this.handleDrag instead of this.handleStart ? #73

Squeezo opened this issue Jul 24, 2017 · 0 comments

Comments

@Squeezo
Copy link
Contributor

Squeezo commented Jul 24, 2017

I was unable to get onChangeStart to fire at all in iOS Safari, until I changed the mapping on line 362 of Rangeslider.js from onTouchStart: this.handleDrag, to onTouchStart: this.handleStart,

Happy to fix it and send you a PR, just wanted to be sure it is actually a bug. thx.
whoisandy added a commit that referenced this issue Sep 19, 2017
@whoisandy
feat(slider): support for click and drag, accessibility
177d433 
closes #50, #52
fixes #60, #71, #73, #79

BREAKING CHANGE:

`rangeslider__label-list` renamed to `rangeslider__labels` & `rangeslider__labels-item`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whoisandy @Squeezo