Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GateTreeError when loading a FlowJo workspace with "." gate name #220

Closed
whitews opened this issue Oct 26, 2024 · 0 comments
Closed

GateTreeError when loading a FlowJo workspace with "." gate name #220

whitews opened this issue Oct 26, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@whitews
Copy link
Owner

whitews commented Oct 26, 2024

Parsing a FlowJo workspace with a gate named either "." or ".." results in the following error:

...flowkit/_models/gate_node.py", line 46, in add_custom_gate raise GateTreeError( flowkit.exceptions.GateTreeError: Custom gate must match the template gate type...

After investigating, this is caused by the anytree library's Resolver.get() method using pattern matching for certain strings. I have an open issue with anytree (see c0fec0de/anytree#269).

The resolution is either to update anytree's Resolver.get() method to allow matching strict node name/paths or for FlowKit to issue an error for certain gate names with a clearer message indicating what the issue is. The latter is problematic because FlowJo allows gate names like "." and "..".

@whitews whitews added the bug Something isn't working label Oct 26, 2024
@whitews whitews added this to the Release version 1.2.0 milestone Oct 26, 2024
@whitews whitews self-assigned this Oct 26, 2024
@whitews whitews closed this as completed Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant