Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support renaming a channel in Sample class #198

Closed
whitews opened this issue May 24, 2024 · 0 comments
Closed

Support renaming a channel in Sample class #198

whitews opened this issue May 24, 2024 · 0 comments
Assignees
@whitews
Labels
enhancement New feature or request
Milestone
Release version 1...

Comments

@whitews
Copy link
Owner

whitews commented May 24, 2024

Currently, the only way to modify channel labels is via Sample.as_dataframe() using the col_names kwarg. Then, re-instantiate a new Sample using the DataFrame. This is clunky for "fixing" a label, plus it loses the original metadata. Provide a method to rename channel PnN labels, with optionally setting a new value for the PnS label.
@whitews whitews added the enhancement New feature or request label May 24, 2024
@whitews whitews added this to the Release version 1.2.0 milestone May 24, 2024
@whitews whitews self-assigned this May 24, 2024
whitews added a commit that referenced this issue Aug 28, 2024
@whitews
support renaming channels in Sample class (closes #198)
60c4ec2
@whitews whitews closed this as completed Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whitews whitews

Labels
enhancement New feature or request
Projects
None yet
Milestone
Release version 1.2.0
Development

No branches or pull requests
1 participant
@whitews