Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libsignal-service-rs #230

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Update libsignal-service-rs #230

merged 3 commits into from
Jan 24, 2024

Conversation

Schmiddiii
Copy link
Contributor

@Schmiddiii Schmiddiii commented Jan 16, 2024

Note: I am unsure about a few things, which are marked as TODO.

This should now be ready, with one additional TODO which needs to be implemented once upstream has PNI.

@Schmiddiii
Copy link
Contributor Author

I now also updated all other (compatible) dependencies, after the merge of whisperfish/libsignal-service-rs#280.

I am currently having issues with building the cli (for reasons unrelated to presage), so I did not update some incompatible packages there.

Copy link
Collaborator

@boxdot boxdot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I think we can remove the todo about the guid, and maybe merge with update pre key bundle for account identity only?

presage/src/manager/registered.rs Outdated Show resolved Hide resolved
presage/src/manager/registered.rs Outdated Show resolved Hide resolved
presage/src/manager/registered.rs Outdated Show resolved Hide resolved
@boxdot
Copy link
Collaborator

boxdot commented Jan 18, 2024

I tested this commit in Gurk. Somehow I get failed to send receipt error=libsignal-service sending error: Error decoding JSON response: Invalid padding at line 1 column 296 sender_uuid=<...>

@Schmiddiii
Copy link
Contributor Author

I tested this commit in Gurk. Somehow I get failed to send receipt error=libsignal-service sending error: Error decoding JSON response: Invalid padding at line 1 column 296 sender_uuid=<...>

Flare does not yet send read receipts, so that did not happen to me. But I guess the error is somewhere in libsignal-service-rs, so maybe ask them about this.

@gferon
Copy link
Collaborator

gferon commented Jan 24, 2024

Quickly tested, LGTM, thanks a lot for working on this!

@gferon gferon merged commit 85580bb into whisperfish:main Jan 24, 2024
4 checks passed
@Schmiddiii Schmiddiii deleted the update-lss branch January 25, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants