-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split project into multiple crates #148
Conversation
A few notes:
|
Just an oversight, done.
Just a matter of preference, I moved it to the root for consistency.
If you look closely, this is already partially what's happening (the associated type inside of |
Maybe the These are nothing you really have to solve though, just minor nitpicks. If you want, feel free to merge. |
It's not really a breaking change though, as the public API stays exactly the same. On the other hand, I expect actually breaking changes to be merged soon, so I bumped the version to 0.6-dev. |
This is a longstanding change that I kept pushing back.
Splitting
presage
into multiple crates bring the following benefits:presage::Error
structpresage-cli
separately and not as an exampleprelude
imports/cc @Schmiddiii