Skip to content

Merge pull request #354 from whisperfish/profile-demo-code #1092

Merge pull request #354 from whisperfish/profile-demo-code

Merge pull request #354 from whisperfish/profile-demo-code #1092

Triggered via push February 8, 2025 13:41
Status Failure
Total duration 2m 25s
Artifacts

ci.yaml

on: push
Check code formatting
3s
Check code formatting
Clippy
1m 25s
Clippy
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

1 error and 3 warnings
Build / Rust nightly
Unable to find any coverage files, was `cargo test` executed correctly?
this `map_or` is redundant: src/sender.rs#L336
warning: this `map_or` is redundant --> src/sender.rs:336:13 | 336 | / self.protocol_store 337 | | .get_sub_device_sessions(&self.local_aci.into()) 338 | | .await 339 | | .map_or(false, |s| !s.is_empty()) | |_________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or = note: `#[warn(clippy::unnecessary_map_or)]` on by default help: use is_ok_and instead | 336 ~ self.protocol_store 337 + .get_sub_device_sessions(&self.local_aci.into()) 338 + .await.is_ok_and(|s| !s.is_empty()) |
the following explicit lifetimes could be elided: 'a: src/push_service/registration.rs#L125
warning: the following explicit lifetimes could be elided: 'a --> src/push_service/registration.rs:125:46 | 125 | pub async fn submit_registration_request<'a>( | ^^ 126 | &mut self, 127 | registration_method: RegistrationMethod<'a>, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
the following explicit lifetimes could be elided: 'r: src/digeststream.rs#L10
warning: the following explicit lifetimes could be elided: 'r --> src/digeststream.rs:10:6 | 10 | impl<'r, R: Read + Seek> Read for DigestingReader<'r, R> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 10 - impl<'r, R: Read + Seek> Read for DigestingReader<'r, R> { 10 + impl<R: Read + Seek> Read for DigestingReader<'_, R> { |