Update docker instructions to use --bind instead of -v. #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etter and approved option now as -v will yield permission errors on some systems. Signed-off-by: Martin Paul Eve <martin@martineve.com>
MartinPaulEve
force-pushed
the
develop
branch
from
8fa8838 to
7cf65f8
Compare
|
Hi, thanks for the pull request! |
Signed-off-by: Martin Paul Eve <martin@martineve.com>
MartinPaulEve
force-pushed
the
develop
branch
from
e045ffb to
774dd5f
Compare
|
OK, so I think this was implicit already in the current documentation but I've rewritten this part of the Docker instructions to make it explicit and to explain what the bind options are actually doing! |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some systems -- my Ubuntu 18.04 install, for instance, using -v to setup the docker mountpoints was throwing permission errors. I couldn't then find the output from the container.
Using the --bind method, which is the approved way to do this now in docker, gets around this problem.
This pull request updates the README.md file to use --bind instead of -v.