Enable whipper to use track title #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABCbum
force-pushed
the
develop
branch
2 times, most recently
from
db5d0f0 to
63a3b59
Compare
|
Thank you. I will review this soon. |
Freso
approved these changes
Dec 13, 2019
There was a problem hiding this comment.
The code looks good, clean, simple to me. I like how you’ve included your reasoning for the change in your PR description – if I was to ask you to change anything, it would be to include this same level of detailed reasoning into your actual commit message(s). :)
See e.g., https://web.archive.org/web/20170115082335/http://ablogaboutcode.com/2011/03/23/proper-git-commit-messages-and-an-elegant-git-history/ and https://chris.beams.io/posts/git-commit/ for pointers on writing better commit messages.
|
Hi @Freso, thanks for your review it encourages me a lot and yes i can make the commit messages more detailed now. :D |
JoeLametta
reviewed
Dec 13, 2019
JoeLametta
reviewed
Dec 13, 2019
JoeLametta
approved these changes
Dec 13, 2019
added 2 commits
December 13, 2019 17:39
track.title = t.get('title', t['recording']['title']).
Since if a track itself doesn't have a title then the track
title is the same with the recording title. Otherwise, a track
has its own title then t['title'] is different from
t['recording']['title'] and whipper chooses t['title'].
[Fixes whipper-team#192]
Signed-off-by: ABCbum <kimlong221002@gmail.com>
Using an existing JSON release file Signed-off-by: ABCbum <kimlong221002@gmail.com>
|
Looks good to me! |
|
Merged, thanks! |
hydrian
pushed a commit
to hydrian/whipper
that referenced
this pull request
Dec 18, 2019
* Enable whipper to use track title if possible
track.title = t.get('title', t['recording']['title']).
Since if a track itself doesn't have a title then the track
title is the same with the recording title. Otherwise, a track
has its own title then t['title'] is different from
t['recording']['title'] and whipper chooses t['title'].
[Fixes whipper-team#192]
Signed-off-by: ABCbum <kimlong221002@gmail.com>
* Add test case to check for track title
Using an existing JSON release file
Signed-off-by: ABCbum <kimlong221002@gmail.com>
Signed-off-by: hydrian <ben.tyger@tygerclan.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitted as a part of GCI competition
The solution i came up with for #192 is that:
track.title = t.get('title', t['recording']['title']).Explaination
Since if a track itself doesn't have a title then the track title is the same with the recording title. Otherwise, a track has its own title then
t['title']is different fromt['recording']['title']and whipper choosest['title'].Note: I also added a test case for this using an existing release JSON file.