Refresh MusicBrainz JSON responses used for testing #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of these dumps predate when MusicBrainz had (re)introduced track MBIDs, so some tests for the code for issue #200 would fail since the JSON dumps didn't contain those IDs. Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
Freso
force-pushed
the
task/refresh-musicbrainz-json-responses
branch
from
d39fe3a to
37e3ecb
Compare
3 tasks
The previous release has gotten a release date added since it was originally dumped from MusicBrainz. Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
The previously used release has since had its [unknown] artist credit resolved since the data was originally taken from MusicBrainz. Using data from this release now: https://musicbrainz.org/release/8478d4da-0cda-4e46-ae8c-1eeacfa5cf37 Specifically: https://musicbrainz.org/track/a04ee451-46c3-3ad6-a815-d7bb8449d605 Signed-off-by: Frederik “Freso” S. Olesen <freso.dk@gmail.com>
Freso
force-pushed
the
task/refresh-musicbrainz-json-responses
branch
from
37e3ecb to
fce00f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of these dumps predate when MusicBrainz had (re)introduced track MBIDs, so some tests for the code for #200 would fail since the JSON dumps didn't contain those IDs.
Original commit followed up by two commits that fix test cases that were now failing, due to the data having been fixed in MusicBrainz.