-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address warnings/errors from various static analysis tools #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeLametta
force-pushed
the
bugfix/idea-issues
branch
8 times, most recently
from
January 18, 2019 10:05
3742381
to
c8eb145
Compare
JoeLametta
changed the title
[WIP] Various fixes/improvements
WIP: Various fixes/improvements
Jan 18, 2019
- Remove redundant escape - Remove erroneous character - Remove duplicate character
JoeLametta
force-pushed
the
bugfix/idea-issues
branch
from
February 2, 2019 18:00
c8eb145
to
4dff396
Compare
- Fix PEP8's line too long warning - Remove useless parentheses - Use triple quotes for docstring - Address pylint's 'inconsistent-return-statements' - Specify string format arguments as logging function parameters - Comment out already disabled block of code - Remove useless else (after return) - Remove useless statement - Do not import already imported module
- Replace print statement with function call - Replace except ..., ...: syntax with except ... as ...: - Simplify obsolete try ... except ... code block - Replace some unicode calls with u-prefixed strings - Do not use `len(SEQUENCE)` to determine if a sequence is empty - Replace dictionary creation - Drop support for GObject static bindings
Also removed unused ones
Also clarified a statement
JoeLametta
force-pushed
the
bugfix/idea-issues
branch
from
February 2, 2019 18:20
4dff396
to
9dc5702
Compare
JoeLametta
changed the title
WIP: Various fixes/improvements
Address warnings/errors from various static analysis tools
Feb 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address warnings/errors from various static analysis tools (PyCharm, Pylint, Flake8).