Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to PyGObject by default #271

Merged
merged 4 commits into from
May 24, 2018
Merged

Conversation

mtdcr
Copy link
Contributor

@mtdcr mtdcr commented May 9, 2018

AFAICT, PyGObject supersedes python-gobject-2.

To quote https://packages.debian.org/en/jessie/python-gobject-2:

This package contains the static Python bindings for gobject, glib, and gio. These are deprecated by dynamic gobject-introspection bindings (which are provided with the python-gobject package), and should not be used in newly written code. These static bindings just exist to provide backwards compatibility for GNOME 2 based software.

In Debian, the Package providing PyGObject is called python-gi (also installed by transitional package python-gobject).

@mtdcr mtdcr changed the title Gobject Switch to PyGObject by default May 9, 2018
@mtdcr mtdcr force-pushed the gobject branch 2 times, most recently from ccd3070 to 4d487d2 Compare May 10, 2018 01:48
@mtdcr
Copy link
Contributor Author

mtdcr commented May 12, 2018

See also: #221 (comment)

@RecursiveForest
Copy link
Contributor

I'm not able to test this on a real CD at the moment but assuming everything works, I approve this changeset.

Copy link
Collaborator

@JoeLametta JoeLametta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Could you also update the .travis.yml file to the new dependency?

@mtdcr
Copy link
Contributor Author

mtdcr commented May 24, 2018

Done. I also added GObject Introspection to the README, because PyGObject needs it for task.py's use of GLib-2.0.

@JoeLametta JoeLametta merged commit 1454037 into whipper-team:master May 24, 2018
@JoeLametta
Copy link
Collaborator

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants