Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace highmaps shallow tests #388

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

anajavi
Copy link
Collaborator

@anajavi anajavi commented Aug 8, 2024

continuation of #385

in order to support react 19

<ContextSpy> is copied from highcharts tests

This should be last shallow-renderer replacement.

@anajavi anajavi requested a review from whawker August 8, 2024 13:21
Copy link
Owner

@whawker whawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on all of this!

@anajavi
Copy link
Collaborator Author

anajavi commented Aug 8, 2024

Great work on all of this!

Thanks!

@anajavi anajavi merged commit e1be138 into master Aug 8, 2024
1 check passed
@anajavi anajavi deleted the refactor/highmaps-shallow branch August 8, 2024 13:32
@anajavi
Copy link
Collaborator Author

anajavi commented Aug 8, 2024

I think react-test-renderer needs to be removed also, fortunately there is only one test suite using that.

All the other tests pass on react@19.0.0-rc.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants