Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prop-types #354

Merged
merged 3 commits into from
Apr 4, 2022
Merged

Remove prop-types #354

merged 3 commits into from
Apr 4, 2022

Conversation

anajavi
Copy link
Collaborator

@anajavi anajavi commented Nov 4, 2021

This drops prop-types entirely as they have been deprecated for several years.

Should not be a breaking change as the builds have removed them anyway:

if (ENV !== 'test') {
config.plugins.push('transform-react-remove-prop-types');
}

@anajavi anajavi requested a review from whawker November 4, 2021 07:06
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2021

Codecov Report

Merging #354 (aad7505) into master (bc85ad5) will decrease coverage by 0.25%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #354      +/-   ##
==========================================
- Coverage   90.82%   90.56%   -0.26%     
==========================================
  Files          82       81       -1     
  Lines        1101     1071      -30     
  Branches      215      214       -1     
==========================================
- Hits         1000      970      -30     
  Misses         90       90              
  Partials       11       11              
Impacted Files Coverage Δ
...highcharts/src/components/Annotation/Annotation.js 88.23% <ø> (-0.66%) ⬇️
...s/react-jsx-highcharts/src/components/Axis/Axis.js 100.00% <ø> (ø)
...x-highcharts/src/components/BarSeries/BarSeries.js 100.00% <ø> (ø)
...x-highcharts/src/components/BaseChart/BaseChart.js 97.72% <ø> (-0.06%) ⬇️
...react-jsx-highcharts/src/components/Chart/Chart.js 100.00% <ø> (ø)
...t-jsx-highcharts/src/components/Credits/Credits.js 100.00% <ø> (ø)
...react-jsx-highcharts/src/components/Debug/Debug.js 12.50% <ø> (-9.73%) ⬇️
...ponents/HighchartsSparkline/HighchartsSparkline.js 36.84% <ø> (-3.16%) ⬇️
...act-jsx-highcharts/src/components/Legend/Legend.js 100.00% <ø> (ø)
...t-jsx-highcharts/src/components/Loading/Loading.js 100.00% <ø> (ø)
... and 16 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@anajavi anajavi merged commit f7661da into master Apr 4, 2022
@anajavi anajavi deleted the remove-prop-types branch April 4, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants