-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow relative URLs and http(s) scheme #37
Conversation
The PR is fine, but Google is neutral on the feature. We won't support unless other browsers ship it first. |
Deno would be in favor of landing this. Allowing only Folks, please let's ship this. It's trivial, it has tests, and it's going to make everyone's lives just slightly less terrible. So, I'll ask for positions from WebKit and Mozilla here again: @annevk, @saschanaz, thoughts? |
1. If |requestURL|'s <a for=url>scheme</a> is "`ws`", set |requestURL|'s <a for=url>scheme</a> | ||
to "`http`". | ||
1. Otherwise, if |requestURL|'s <a for=url>scheme</a> is "`wss`", set |requestURL|'s | ||
<a for=url>scheme</a> to "`https`". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do this normalization upfront in the constructor so it doesn't leak out in a number of places.
And thereby relative URLs. They are instantly normalized to the ws: and wss: schemes. Tests: web-platform-tests/wpt#39955. Closes #37.
Since there was no follow-up, I decided to move forward with this in #45 with a slightly different approach. Hope that's okay. |
Addresses #20.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff