Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RFC2119 keyword warnings #223

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Conversation

yoshisatoyanagisawa
Copy link
Contributor

@yoshisatoyanagisawa yoshisatoyanagisawa commented Mar 4, 2024

The current specification uses "should" and "may" in non-normative sections. They are recognized as RFC2119 keywords. This change omit using them there.

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

The current specification uses "should" and "may" in non-normative
sections.  They are recognized as RFC2119 keywords.
This change omit using them there.
Copy link
Collaborator

@jeremyroman jeremyroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after resolution of one comment

spec.bs Outdated Show resolved Hide resolved
Co-authored-by: Jeremy Roman <jeremy@jeremyroman.com>
@jeremyroman
Copy link
Collaborator

This probably should be Editorial per https://github.com/whatwg/meta/blob/main/COMMITTING.md. I think I can do that while merging.

@jeremyroman jeremyroman merged commit 502f120 into whatwg:main Mar 5, 2024
2 checks passed
@yoshisatoyanagisawa
Copy link
Contributor Author

thanks for the review!

@yoshisatoyanagisawa yoshisatoyanagisawa deleted the minor_fix branch March 5, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants