Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not initialize a URLPatternInit member to null in "initialize a URLPattern" #213

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Do not initialize a URLPatternInit member to null in "initialize a URLPattern" #213

merged 2 commits into from
Jan 29, 2024

Commits on Jan 26, 2024

  1. Do not initialize a URLPatternInit member to null in "initialize a UR… 

    …LPattern"

It is not valid for the baseURL dictionary member to be null, only
either absent or a USVString. Instead, this should be omitted from the
dictionary altogether if no string was provided to this algorithm.

Any string which is invalid will fail later on, when it is to be parsed
as a URL.

Fixes whatwg#204.
    @jeremyroman
    jeremyroman committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    b0a6dc0 View commit details
    Browse the repository at this point in the history

  2. use map/set explicitly

    @jeremyroman
    jeremyroman committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    3361609 View commit details
    Browse the repository at this point in the history