Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More strict check for init["baseURL"] in URLPatternInit processing #205

Closed
wants to merge 1 commit into from

Conversation

sisidovski
Copy link
Collaborator

@sisidovski sisidovski commented Jan 15, 2024

init["baseURL"] is initialized with null, and map-exists only checks if there exists an entry with the key. This commit adds null or empty string check for init["baseURL"] in URLPatternInit processing.

  • At least two implementers are interested (and none opposed):
    • Google Chrome
  • Tests are written and can be reviewed and commented upon at:
    • n/a (this is a fix to how the spec expresses this, but does not represent a behavior change, and existing tests cover this behavior)
  • Implementation bugs are filed:
    • Chromium: n/a (believed to work correctly in Chromium)
    • Gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=1731418 (vendor does not yet implement the spec)
    • WebKit: [no known URLPattern bug] (vendor does not yet implement the spec)
    • Deno: n/a (no reason to believe a change is required)
    • kenchris/urlpattern-polyfill: n/a (no reason to believe a change is required)
  • MDN issue is filed: n/a (change is on a spec detail not expressly documented)
  • The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)


Preview | Diff

init["baseURL"] is initialized with null, and map-exists only checks if
there exists an entry with the key. This commit adds null or empty
string check for init["baseURL"] in URLPatternInit processing.
@sisidovski
Copy link
Collaborator Author

This seems to be unnecessary, closing.

@sisidovski sisidovski closed this Jan 15, 2024
@sisidovski sisidovski deleted the patch-baseURL branch January 15, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant