Updates the regular expression to work with the v flag instead of u
#188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nit: no period at the end of the first line, per https://github.com/whatwg/meta/blob/main/COMMITTING.md#commit-messages I'd probably remove the "this PR" bit from the final commit message since at that point it's not a PR, and the rest repeats the first line. |
jeremyroman
approved these changes
Sep 13, 2023
sisidovski
changed the title
v flag instead of u.v flag instead of u
|
Nice! Consider filing a Chromium bug to implement this :) |
|
Filed! crbug.com/1482263 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the regular expression part to work with
vflag instead ofu.This will fix #178.
Preview | Diff