Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand introductory text and examples #187

Merged
merged 4 commits into from
Sep 13, 2023

Conversation

jeremyroman
Copy link
Collaborator

@jeremyroman jeremyroman commented Sep 13, 2023

Some simple introductory examples are added, along with some brief
overview text of both URL patterns and (component-specific) pattern
strings.

Some more detailed examples already exist within the relevant parsing
code.

This contributes to resolving #127.


Preview | Diff

Some simple introductory examples are added, along with some brief
overview text of both URL patterns and (component-specific) pattern
strings.

Some more detailed examples already exist within the relevant parsing
code.

This contributes to resolving whatwg#127.
@jeremyroman jeremyroman changed the title Intro examples Expand introductory text and examples Sep 13, 2023
spec.bs Outdated Show resolved Hide resolved
Copy link
Collaborator

@sisidovski sisidovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ nits. Thank you!

spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@jeremyroman jeremyroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jeremyroman jeremyroman merged commit d9af8a1 into whatwg:main Sep 13, 2023
2 checks passed
@jeremyroman jeremyroman deleted the intro-examples branch September 13, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants