Remove erroneous prefix check when generating string. (#145) #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes another issue with generating canonical pattern strings as described in #145. In this case the prefix check incorrectly prevented us from protecting a named group from following character if there was an implicit prefix. For example, for a pathname `/:foo\\bar` we would incorrectly produce `/:foobar` instead of `{/:foo}bar`.
|
@domenic PTAL. |
wanderview
added a commit
to wanderview/urlpattern-polyfill
that referenced
this pull request
Jan 20, 2022
…is#62) This addresses another issue from whatwg/urlpattern#161. It corresponds to this implementation CL: https://chromium-review.googlesource.com/c/chromium/src/+/3405148
kenchris
pushed a commit
to kenchris/urlpattern-polyfill
that referenced
this pull request
Jan 20, 2022
This addresses another issue from whatwg/urlpattern#161. It corresponds to this implementation CL: https://chromium-review.googlesource.com/c/chromium/src/+/3405148
crowlKats
added a commit
to crowlKats/rust-urlpattern
that referenced
this pull request
Jan 20, 2022
domenic
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes another issue with generating canonical pattern strings as described
in #145. In this case the prefix check incorrectly prevented us from
protecting a named group from following character if there was an implicit
prefix. For example, for a pathname
/:foo\\barwe would incorrectly produce/:foobarinstead of{/:foo}bar.Preview | Diff