Support pattern syntax in ipv6 hostnames. (Fixes #115) #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@domenic can you please review this PR with further ipv6 fixes? I'm not sure I handled the code point/infra stuff right. Thanks. |
domenic
reviewed
Sep 3, 2021
There was a problem hiding this comment.
This all looks great, but you have indeed found some areas where Infra does not give you a 100% rigorous foundation. In all cases though, it's pretty unambiguous what you mean, so it's mostly feedback for Infra and not something that prevents this PR from being merge-worthy.
wanderview
force-pushed
the
dev-ipv6-pattern
branch
from
2208476
to
4c44471
Compare
|
Updated. PTAL. |
wanderview
force-pushed
the
dev-ipv6-pattern
branch
from
4c44471
to
0b0c53a
Compare
domenic
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff