Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Process relative pathnames in URLPatternInit. (Fixes #106) #107

Merged
merged 3 commits into from
Aug 31, 2021
Merged

Process relative pathnames in URLPatternInit. (Fixes #106) #107

merged 3 commits into from
Aug 31, 2021

Conversation

wanderview
Copy link
Member

@wanderview wanderview commented Aug 31, 2021 •
edited by pr-preview bot
Loading

@wanderview wanderview mentioned this pull request Aug 31, 2021
Closed
@wanderview
Copy link
Member Author

@domenic can you please review this pull request? The related c++ code is:

https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/url_pattern/url_pattern.cc;l=149-169;drc=9e20a8d10d90b04cfee4930da49704efc28ce418

domenic
domenic approved these changes Aug 31, 2021
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
wanderview and others added 2 commits August 31, 2021 12:24
@wanderview @domenic
Apply suggestions from code review
aab917c 
Co-authored-by: Domenic Denicola <d@domenic.me>
@wanderview
address review feedback
a145466
@wanderview wanderview merged commit 7d8da85 into main Aug 31, 2021
@wanderview wanderview deleted the dev-relative-pathname branch August 31, 2021 17:42
crowlKats added a commit to crowlKats/rust-urlpattern that referenced this pull request Aug 31, 2021
@crowlKats
whatwg/urlpattern#107
ccd08de
@sisidovski sisidovski mentioned this pull request Nov 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wanderview @domenic