Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix matching regexp for :name* patterns #99

Closed
wanderview opened this issue Aug 26, 2021 · 4 comments
Closed

fix matching regexp for :name* patterns #99

wanderview opened this issue Aug 26, 2021 · 4 comments

Comments

@wanderview
Copy link
Member

We have found a bug in both upstream path-to-regexp and the chromium implementation. We will need to update the spec to fix this bug as well.

@kettanaito
Copy link

I can provision the suggested fix to path-to-regexp and chromium, adding tests so we could catch any regressions. Would this be okay with you?

@wanderview
Copy link
Member Author

I already have a fix written for chrome at:

https://chromium-review.googlesource.com/c/chromium/src/+/3123654

If you want to make a PR for pillarjs/path-to-regexp#260, though, that would be great. I think the offending line of code is:

https://github.com/pillarjs/path-to-regexp/blob/master/src/index.ts#L566

@kettanaito
Copy link

@wanderview, yeah, saw your fix.

Sure, I'll open a pull request to path-to-regexp and ensure it's covered there. Should address this today-tomorrow.

wanderview added a commit that referenced this issue Aug 26, 2021
Fix the regexp generated for some patterns. (Fixes #99)
@kettanaito
Copy link

Opened a pull request to address the issue in path-to-regexp: pillarjs/path-to-regexp#261

wanderview added a commit that referenced this issue Aug 31, 2021
Update spec text to match final implementation. (#99)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants