Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect type in group name assignment #208

Closed
rubycon opened this issue Jan 19, 2024 · 0 comments · Fixed by #215
Closed

Incorrect type in group name assignment #208

rubycon opened this issue Jan 19, 2024 · 0 comments · Fixed by #215

Comments

@rubycon
Copy link
Contributor

rubycon commented Jan 19, 2024

What is the issue with the URL Pattern Standard?

The pattern parser field next numeric name is of type number but in add part it's assigned to the group name which is of type string without conversion:

  1. Otherwise if regexp or wildcard token is not null:
    1. Set name to parser’s next numeric name.

It should be serialized to a string before assignment.
@rubycon rubycon changed the title Incorrect type in numeric group name assignment Incorrect type in group name assignment Jan 19, 2024
jeremyroman added a commit to jeremyroman/urlpattern that referenced this issue Jan 26, 2024
@jeremyroman
Serialize the next numeric name
50c768a 
We need to explicitly convert this from an integer to a string.

Fixes whatwg#208.
@jeremyroman jeremyroman mentioned this issue Jan 26, 2024
Merged
5 tasks
jeremyroman added a commit that referenced this issue Jan 29, 2024
@jeremyroman
Serialize the next numeric name
1259680 
We need to explicitly convert this from an integer to a string.

Fixes #208.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Serialize the next numeric name jeremyroman/urlpattern
1 participant
@rubycon