Skip to content

Commit

Permalink
Do not initialize a URLPatternInit member to null in "initialize a UR…
Browse files Browse the repository at this point in the history
…LPattern"

It is not valid for the baseURL dictionary member to be null, only
either absent or a USVString. Instead, this should be omitted from the
dictionary altogether if no string was provided to this algorithm.

Any string which is invalid will fail later on, when it is to be parsed
as a URL.

Fixes #204.
  • Loading branch information
jeremyroman authored Jan 29, 2024
1 parent 226dee4 commit c9c56ee
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion spec.bs
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ Each {{URLPattern}} object has an associated <dfn for=URLPattern>hash component<
1. If |input| is a [=scalar value string=] then:
1. Set |init| to the result of running [=parse a constructor string=] given |input|.
1. If |baseURL| is null and |init|["{{URLPatternInit/protocol}}"] does not [=map/exist=], then throw a {{TypeError}}.
1. Set |init|["{{URLPatternInit/baseURL}}"] to |baseURL|.
1. If |baseURL| is not null, [=map/set=] |init|["{{URLPatternInit/baseURL}}"] to |baseURL|.
1. Otherwise:
1. [=Assert=]: |input| is a {{URLPatternInit}}.
1. If |baseURL| is not null, then throw a {{TypeError}}.
Expand Down

0 comments on commit c9c56ee

Please sign in to comment.