Stop after setting an url’s query to null. #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don’t go on to setting it to the empty string in a following step, which makes setting to null pointless This is probably what was intended, as it is similar to what happens in the `hash` setter.
annevk
pushed a commit
that referenced
this pull request
Apr 14, 2016
Don’t go on to setting it to the empty string in a following step, which makes setting to null pointless. This is probably what was intended, as it is similar to what happens in the `hash` setter. PR: #114
|
Thank you, landed as 4f1c2dd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don’t go on to setting it to the empty string in a following step, which makes setting to null pointless
This is probably what was intended, as it is similar to what happens in the
hashsetter.