Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New standard: URLPattern #215

Closed
sisidovski opened this issue Oct 2, 2023 · 10 comments
Closed

New standard: URLPattern #215

sisidovski opened this issue Oct 2, 2023 · 10 comments

Comments

@sisidovski
Copy link

Based on the discussion at the TPAC 2023 and follow ups, we’ll propose standardizing URLPattern API.

URLPattern is the API providing a web platform primitive for matching URLs. The pattern syntax is adopted from the popular path-to-regexp javascript library and is more ergonomic than using regular expressions.

@jeremyroman and @sisidovski will edit the spec, who took over the work from @wanderview.

Some questions to the sg:

For the short name, I feel just using “urlpattern” is fine. We suggest using a "*" in a circle as the icon.

@cwilso
Copy link
Contributor

cwilso commented Oct 4, 2023

@annevk and @tantek have approved of this, as well as myself.

@annevk
Copy link
Member

annevk commented Oct 4, 2023

https://github.com/whatwg/meta/blob/main/NEW-STANDARD.md has a checklist to go over. 2 might be an item you'd be willing to cover @sisidovski? I think @domenic was willing to help with the remainder. I'd be happy to review.

To transfer the repository it might make the most sense to move it to @domenic and then he can move it further. From experience GitHub will handle the redirects across.

@cwilso
Copy link
Contributor

cwilso commented Oct 4, 2023

I was talking with @foolip about this. Unfortunately, the github.com references will redirect, but the github.io hosting won't.

@jyasskin
Copy link
Member

jyasskin commented Oct 4, 2023

We can make the github.io hosting redirect too, by imitating https://github.com/WICG/wicg.github.io/blob/main/picture-in-picture/index.html.

@sisidovski
Copy link
Author

Thank you all!

https://github.com/whatwg/meta/blob/main/NEW-STANDARD.md has a checklist to go over. 2 might be an item you'd be willing to cover @sisidovski? I think @domenic was willing to help with the remainder. I'd be happy to review.

Yes. Now I'm working on the logo work. Should I also work on 4?

@domenic
Copy link
Member

domenic commented Oct 5, 2023

A pull request for 4 would be appreciated, but there is no urgency since we will not want to merge it until we have also completed 1.

One field that might be especially mysterious is review_draft_schedule. That is two months of the year review drafts are generated. It looks like we are load balancing between (1, 7), (2, 8), and (3, 9), so pick whichever of those has the fewest specs currently.

@annevk
Copy link
Member

annevk commented Oct 5, 2023

(3, 9) is the one we want so it would join "WHATWG RDs (4)" (for those on the Review Draft calendar invite).

The next standard we add will require a new calendar entry if we stick to publishing about 5 a month. (There's also (6, 12), so we're up to 20 standards including this one.)

@annevk
Copy link
Member

annevk commented Oct 11, 2023

Just wanted to note that the SG discussed this briefly yesterday and from the SG's perspective all is in order here. Technically this is a Workstream editor decision, but the SG appreciates the heads up as it also involves changes to db.json and derivative documents the SG is responsible for.

domenic pushed a commit to whatwg/whatwg.org that referenced this issue Oct 13, 2023
@domenic
Copy link
Member

domenic commented Oct 13, 2023

I've made some progress on the checklist:

The next step will be transferring the repository and running spec-factory. I will work on that next week.

domenic added a commit that referenced this issue Oct 17, 2023
domenic added a commit that referenced this issue Oct 18, 2023
domenic added a commit to whatwg/urlpattern that referenced this issue Oct 20, 2023
* Update repository files using whatwg/spec-factory.
* Use the WHATWG template.
* Add an Acknowledgments section and IPR statement.
* Sentence-case all headings.
* Add missing example IDs.
* Fix some markup in the introductory example to work well with WHATWG styling.
* Fix some invalid HTML, double-"the" typos, and usage of "and/or" disallowed by the linter.
* Reword some disallowed uses of RFC 2119 keywords, and mark up some uses of "optional" as allowed.

Part of #190. See also whatwg/sg#215.
@whatwg whatwg deleted a comment from ytlim696 Dec 19, 2023
@annevk
Copy link
Member

annevk commented Dec 19, 2023

Let's close this. Thanks everyone for getting this done!

@annevk annevk closed this as completed Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants