Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: fix url argument to WebDriver BiDi fragment navigated #8939

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

foolip
Copy link
Member

@foolip foolip commented Feb 23, 2023

In the "navigate to a fragment" algorithm there is no resource variable
or argument. Simply use the url argument instead.

Also fix the order of the arguments to be consistent (id, status, url)
in another invocation.

  • At least two implementers are interested (and none opposed):
  • Tests are written and can be reviewed and commented upon at:
  • Implementation bugs are filed:
    • Chromium: …
    • Gecko: …
    • WebKit: …
    • Deno (only for timers, structured clone, base64 utils, channel messaging, module resolution, web workers, and web storage): …
    • Node.js (only for timers, structured clone, base64 utils, channel messaging, and module resolution): …
  • MDN issue is filed: …

(See WHATWG Working Mode: Changes for more details.)


/browsing-the-web.html ( diff )

In the "navigate to a fragment" algorithm there is no resource variable
or argument. Simply use the url argument instead.

Also fix the order of the arguments to be consistent (id, status, url)
in another invocation.
@foolip foolip changed the title Fix url argument to WebDriver BiDi fragment navigated Editorial: fix url argument to WebDriver BiDi fragment navigated Feb 23, 2023
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@domenic domenic merged commit 43cc9ce into main Feb 24, 2023
@domenic domenic deleted the foolip/bidi-callbacks branch February 24, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants