Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds 'Consume User Activation of Window' via WebDriver #8609

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Dec 12, 2022

Originally proposed in Web Driver repo, but @jgraham asked us to move it to HTML instead.

Closes #8608

Related discussion web-platform-tests/wpt#36727

RFC for Web Platform Tests: web-platform-tests/rfcs#128

Implementation in testdriver.js: web-platform-tests/wpt#37176

(See WHATWG Working Mode: Changes for more details.)


/index.html ( diff )
/interaction.html ( diff )
/references.html ( diff )

@marcoscaceres marcoscaceres force-pushed the consume_wd branch 2 times, most recently from 995d918 to aa33126 Compare December 12, 2022 03:48
@marcoscaceres marcoscaceres marked this pull request as draft December 12, 2022 03:50
@marcoscaceres marcoscaceres force-pushed the consume_wd branch 3 times, most recently from 78abba8 to a3ea121 Compare December 12, 2022 04:20
@marcoscaceres marcoscaceres marked this pull request as ready for review December 12, 2022 04:24
source Outdated Show resolved Hide resolved
@mustaqahmed
Copy link
Contributor

This is great, thanks! I just filed this Chrome bug: https://crbug.com/1400264.

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of editorial issues, plus the big question as to why this is working on the top-level browsing context instead of the current one.

source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Outdated Show resolved Hide resolved
@marcoscaceres
Copy link
Member Author

@jgraham, would you be the right contact for this on the Mozilla side? Would like to confirm that Mozilla is not opposed (and hopefully get a bug filed for this too in Gecko's bug tracker).

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs rebase. Then we can merge!

@domenic domenic self-assigned this Jan 11, 2023
@foolip
Copy link
Member

foolip commented Jan 31, 2023

@marcoscaceres can you rebase this? It would be nice to unblock web-platform-tests/rfcs#128.

An implementation bug for Chromium would be nice too.

@mustaqahmed
Copy link
Contributor

An implementation bug for Chromium would be nice too.

https://crbug.com/1400264

@marcoscaceres
Copy link
Member Author

Rebased... hopefully good to merge. 🙏

@marcoscaceres
Copy link
Member Author

filed gecko bug and updated OP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add a means to consume user activation through automated testing
5 participants