-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds 'Consume User Activation of Window' via WebDriver #8609
Conversation
995d918
to
aa33126
Compare
78abba8
to
a3ea121
Compare
a3ea121
to
f63ef87
Compare
This is great, thanks! I just filed this Chrome bug: https://crbug.com/1400264. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of editorial issues, plus the big question as to why this is working on the top-level browsing context instead of the current one.
@jgraham, would you be the right contact for this on the Mozilla side? Would like to confirm that Mozilla is not opposed (and hopefully get a bug filed for this too in Gecko's bug tracker). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but needs rebase. Then we can merge!
@marcoscaceres can you rebase this? It would be nice to unblock web-platform-tests/rfcs#128. An implementation bug for Chromium would be nice too. |
|
75eb0f6
to
c27903e
Compare
Rebased... hopefully good to merge. 🙏 |
filed gecko bug and updated OP. |
Originally proposed in Web Driver repo, but @jgraham asked us to move it to HTML instead.
Closes #8608
Related discussion web-platform-tests/wpt#36727
RFC for Web Platform Tests: web-platform-tests/rfcs#128
Implementation in testdriver.js: web-platform-tests/wpt#37176
(See WHATWG Working Mode: Changes for more details.)
/index.html ( diff )
/interaction.html ( diff )
/references.html ( diff )