Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report ResourceTiming for video posters and image inputs #7539

Merged
merged 4 commits into from
Feb 17, 2022

Conversation

noamr
Copy link
Collaborator

@noamr noamr commented Jan 27, 2022

  • At least two implementers are interested (and none opposed):
    • Already implemented
  • Tests are written and can be reviewed and commented upon at:
    • 32566
    • Video poster is already tested
  • Implementation bugs are filed:

/input.html ( diff )
/media.html ( diff )

source Outdated
source</span> given the <code>input</code> element to <span data-x="concept-event-fire">fire an
event</span> named <code data-x="event-error">error</code> on the <code>input</code> element.</p>
by the <span>networking task source</span> once the resource has been fetched, must perform the
following steps given a <span data-x="concept-response">response</span> <var>response</var>:</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this use processResponseEndOfBody too? I guess by merging these two steps into the existing two-step algorithm above that ends with "Fetch request".

The intermediate paragraphs are a mess, but I think we can mostly just keep them as-is, while improving this specific one that you're touching by merging it into the more formal algorithm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants