Fix #744: clarify control groups and control group owner objects #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <p>The corresponding <code>Document</code> object or <code>dialog</code> element is the created | ||
| <span>control group</span>'s <dfn data-x="control group owner object">owner object</dfn>. (There | ||
| is always a 1:1 mapping of <span data-x="control group">control groups</span> to <span | ||
| data-x="control group owner object">control group owner objects</span>.)</p> |
There was a problem hiding this comment.
"a control group to a control group owner object" perhaps? Otherwise it might read like there's a mapping between the groups.
There was a problem hiding this comment.
I don't think so. A couple reasons:
- Precedent: "There is always a 1:1 mapping of global objects to environment settings objects"
- The meaning of 1:1 mapping is between sets. "There is a 1:1 mapping between the numbers { 0, 2, 4 } and the numbers { 1, 2, 3 }." You can't have a mapping between a single thing and another single thing (e.g. a control group and a control gorup owner object).
domenic
force-pushed
the
clarify-control-groups
branch
from
2a88493 to
9d179e4
Compare
|
LGTM |
This attempts to clarify: - How control groups are created (previously we were just told that focusable areas belong to them) - The relationship between control groups and control group owners It also removes the redundant distinction between "control group owners" and "control group owner objects", settling on the latter since it was more prevalent.
annevk
force-pushed
the
clarify-control-groups
branch
from
9d179e4 to
9194856
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to clarify:
focusable areas belong to them)
It also removes the redundant distinction between "control group owners"
and "control group owner objects", settling on the latter since it was
more prevalent.
Reviewers = @TakayoshiKochi plus another editor who feels brave enough to dive into this stuff, or at least just critique my work from an editorial point of view.