-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: Make pageshow.persisted non-normative refer to salvageable… #6558
Conversation
Hmm, I wonder if we should keep the list. It's kinda nice to have a list of things in the note instead of having to go through the reference. Referring to the "salvageable" concept instead of using "unsalvageable" sounds good though. The WebSockets bit is specified here, but there's an open issue about it: #1931 |
Thanks for the pointer for the WebSockets bit - I missed it. |
e5d9307
to
2d3f20e
Compare
@rakina I addressed your comment. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks like a nice editorial change. I have some suggestions to make it even more readable, and probably @domenic needs to review this too (for the write access bit?)
2d3f20e
to
3902f60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thanks, Rakina! @domenic Can I have your review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Editorial change - skipping the checklist template.
This is an editorial change which attempts to remove the unsalvageable normative text which I was confused when I was reading through it. We now have the
#concept-document-salvageable
, so this PR attempts to replace the enumerated conditions with its reference.Open Question:
/browsing-the-web.html ( diff )