-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow import() in worklets #6070
Conversation
@padenot do you know if we have tests for this for audio worklets? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorially looks good. Glad it's as simple as this.
I confirm this. |
I double-checked this spec change is aligned with Chrome implementation. For testing on WPTs, I have no ideas other than using API specific features ("Awkward communication") like |
I added a basic paint worklet test in web-platform-tests/wpt#26175. Any review is appreciated. I don't feel comfortable writing a test for audio worklets because they seem to use some nonstandard test harness. |
You can also use the standard harness in the normal way. |
… in paint worklets, a=testonly Automatic update from web-platform-tests Test that dynamic import() is disallowed in paint worklets Follows whatwg/html#6070. -- wpt-commits: 43fb3b28428eaa6a5eb59fb4fda4b827bf1dced7 wpt-pr: 26175
… in paint worklets, a=testonly Automatic update from web-platform-tests Test that dynamic import() is disallowed in paint worklets Follows whatwg/html#6070. -- wpt-commits: 43fb3b28428eaa6a5eb59fb4fda4b827bf1dced7 wpt-pr: 26175 UltraBlame original commit: 361c76d4900e19e2387730a053a29758c869f7c2
… in paint worklets, a=testonly Automatic update from web-platform-tests Test that dynamic import() is disallowed in paint worklets Follows whatwg/html#6070. -- wpt-commits: 43fb3b28428eaa6a5eb59fb4fda4b827bf1dced7 wpt-pr: 26175 UltraBlame original commit: 361c76d4900e19e2387730a053a29758c869f7c2
… in paint worklets, a=testonly Automatic update from web-platform-tests Test that dynamic import() is disallowed in paint worklets Follows whatwg/html#6070. -- wpt-commits: 43fb3b28428eaa6a5eb59fb4fda4b827bf1dced7 wpt-pr: 26175 UltraBlame original commit: 361c76d4900e19e2387730a053a29758c869f7c2
… in paint worklets, a=testonly Automatic update from web-platform-tests Test that dynamic import() is disallowed in paint worklets Follows whatwg/html#6070. -- wpt-commits: 43fb3b28428eaa6a5eb59fb4fda4b827bf1dced7 wpt-pr: 26175
Closes w3c/css-houdini-drafts#506.
(See WHATWG Working Mode: Changes for more details.)
/webappapis.html ( diff )