Add a note about limiting the image density srcset takes into account #5901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eeeps - can you take a look to see if I reached the right conclusions from your research? |
What I see in the image below is: 2.2 is apparent precision only and not really helpful. |
annevk
reviewed
Sep 11, 2020
| @@ -28273,6 +28273,12 @@ was an English <a href="/wiki/Music_hall">music hall</a> singer, ...</code | |||
| <li><p>Return <var>selected source</var> and its associated pixel density.</p></li> | |||
| </ol> | |||
|
|
|||
| <p class="note"><a | |||
| href="https://observablehq.com/@eeeps/visual-acuity-and-device-pixel-ratio">Research</a> | |||
There was a problem hiding this comment.
This should be in the reference section. Also not sure we should call it research unless it's a peer-reviewed paper?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4421
Chrome plans to experiment with limiting the density value that srcset takes into account when selecting sources.
As the image source selection algorithm is UA-specific, other implementer may or may not try to follow, but I thought that adding a note to that effect can help.
The change is not WPT testable as:
a) It's a note.
b) It refers to user-agent specific selection
If needed, I'm happy to file relevant implementation bugs.
(See WHATWG Working Mode: Changes for more details.)
💥 Error: Wattsi server error 💥
PR Preview failed to build. (Last tried on Jan 15, 2021, 8:00 AM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.