Fix reloads to not wipe out future session history #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1578. When performing a reload via location.reload() or a user interface element, it seems more correct to go down the "entry update" path, instead of going down the normal path and turning on "replacement enabled". The normal path wipes out all session history entries after the current one, which is not what browsers do when reloading.
|
LGTM |
|
lgtm, but seems not to be merged yet. |
|
Yes, it needed a LGTM from an editor, and then I merge it into master :). I'll do that now. Thanks for reporting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1578. When performing a reload via location.reload() or a user
interface element, it seems more correct to go down the "entry update"
path, instead of going down the normal path and turning on "replacement
enabled". The normal path wipes out all session history entries after
the current one, which is not what browsers do when reloading.
I removed the non-normative note entirely since it seems just wrong in general now.
/cc @toyoshim @smaug---- @annevk